Platform: Code4rena
Start Date: 26/05/2022
Pot Size: $75,000 USDT
Total HM: 31
Participants: 71
Period: 7 days
Judge: GalloDaSballo
Total Solo HM: 18
Id: 126
League: ETH
Rank: 53/71
Findings: 1
Award: $103.42
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: IllIllI
Also found by: 0x1f8b, 0x29A, 0xDjango, 0xNazgul, 0xf15ers, BouSalman, Chom, Deivitto, Dravee, ElKu, FSchmoede, Funen, GimelSec, Hawkeye, MiloTruck, Picodes, SecureZeroX, SmartSek, TerrierLover, WatchPug, _Adam, asutorufos, berndartmueller, c3phas, catchup, cccz, cogitoergosumsw, cryptphi, csanuragjain, delfin454000, dipp, ellahi, gzeon, hansfriese, horsefacts, hyh, kirk-baird, minhquanym, oyc_109, pauliax, reassor, robee, sashik_eth, shenwilly, simon135, sorrynotsorry, sseefried, unforgiven, xiaoming90, z3s
103.4161 USDT - $103.42
The donate function in VE3DRewardPool.sol does not seem to support tokens whose balances change during a transfer, such as deflationary and fee-on-transfer tokens. The impact of this is that the rewardTokenInfo corresponding to that token may have incorrect values.
To account for these tokens, consider adding balance checks directly before and after the transfer of the tokens and use the difference to update the token info.
To ensure that necessary variable addresses aren't set to the zero address, consider adding zero address checks for all relevant addresses supplied as input to the constructors and setters.
#0 - GalloDaSballo
2022-07-07T00:03:02Z
Valid Low
Valid Low
2 L