Livepeer Onchain Treasury Upgrade - ether_sky's results

Lines of code

https://github.com/code-423n4/2023-08-livepeer/blob/a3d801fa4690119b6f96aeb5508e58d752bda5bc/contracts/bonding/BondingManager.sol#L348-L352

Vulnerability details

Impact

When we updated a transcoder with rewards and then try to update a transcoder with fees, it incorrectly calculates the reward generated in the current round for that transcoder, which also incorrectly calculates the previous pool's cumulativeRewardFactor, then the current pool's incorrect cumulativeRewardFactor.

Proof of Concept

If the transcoder has already been updated with a reward, lastRewardRound is equivalent to currentRound. And let's assume the previous pool's cumulativeRewardFactor is zero. In this case, we calculate the previous pool's cumulativeRewardFactor value from the current pool's ``cumulativeRewardFactor```. That is, it falls to the below part.

if (prevEarningsPool.cumulativeRewardFactor == 0 && lastRewardRound == currentRound) {
    IMinter mtr = minter();
    uint256 rewards = PreciseMathUtils.percOf(
       mtr.currentMintableTokens().add(mtr.currentMintedTokens()),
       totalStake,
       currentRoundTotalActiveStake
    );

    ...
}

The logic behind this is below.

rewards = mtr.currentMintableTokens() * totalStake / currentRoundTotalActiveStake;
delegatorsRewards = rewards - treasuryRewards - transcoderCommissionRewards;
prevEarningsPool.cumulativeRewardFactor * (1 + delegatorsRewards / totalStake) = earningsPool.cumulativeRewardFactor;

But in Minter, we calculate the rewards for the transcoder like below.

uint256 mintAmount = MathUtils.percOf(currentMintableTokens, _fracNum, _fracDenom);

As you can see, it doesn't involve currentMintedTokens because currentMintableTokens is constant during the round.

And also in Minter, we used MathUtils but PreciseMathUtils in BondingManager. This is also bug I think.

Tools Used

Manual audit

Recommended Mitigation Steps

Update like below.

uint256 rewards = MathUtils.percOf(
    mtr.currentMintableTokens(),
    totalStake,
    currentRoundTotalActiveStake
);

Assessed type

Error