Float Capital contest - evertkors's results

based on https://docs.code4rena.com/roles/wardens/judging-criteria#estimating-risk-tl-dr upgrading this to 1

Unfortunately this is still needed. _mintAccumulatedFloatAndExecuteOutstandingShifts(marketIndex, msg.sender); modifies the userAmountStaked[token][msg.sender], so you do need to read that value again.

See below image:

Verdict: given the code this optimization introduces a bug. Final code indeed only reads userAmountStaked once, but that is due to other optimizations.

Not an exact duplicate of #25, #24 and #18 (different variable - but same optimization suggested -closing)

I am not sure where the divergence in code is here but the line that was reference by the warden is

require(userAmountStaked[token][msg.sender] > 0, "nothing to withdraw");
    _mintAccumulatedFloat(marketIndex, msg.sender);

    userAmountStaked[token][msg.sender] = userAmountStaked[token][msg.sender] - amount;

where the _mintAccumulatedFloat does not modify the userAmountStaked. Given this information, I am reopening the issue.