Swivel v3 contest - exd0tpy's results

The Capital-Efficient Protocol For Fixed-Rate Lending.

General Information

Platform: Code4rena

Start Date: 12/07/2022

Pot Size: $35,000 USDC

Total HM: 13

Participants: 78

Period: 3 days

Judge: 0xean

Total Solo HM: 6

Id: 135

League: ETH

Swivel

Findings Distribution

Researcher Performance

Rank: 52/78

Findings: 2

Award: $69.98

🌟 Selected for report: 0

🚀 Solo Findings: 0

Non Risk

typo in comment

https://github.com/code-423n4/2022-07-swivel/blob/daf72892d8a8d6eaa43b9e7d1924ccb0e612ee3c/Swivel/Swivel.sol#L677

fix reddem to redeem.

change internal function name

common naming convention of internal function is _functionName.

avoid clash like withdraw in Swivel.sol.

#0 - robrobbins

2022-08-30T23:49:02Z

withdraw is not a clash. Solidity allows for method signature overloads.

_dangling underscores are not a style we support.

Awards

25.7185 USDC - $25.72

Labels

bug
duplicate
G (Gas Optimization)
wontfix

External Links

Use private in constant value

https://github.com/code-423n4/2022-07-swivel/blob/daf72892d8a8d6eaa43b9e7d1924ccb0e612ee3c/Swivel/Swivel.sol#L25-L35

string constant public NAME = 'Swivel Finance'; string constant public VERSION = '3.0.0'; uint256 constant public HOLD = 3 days; ... uint16 constant public MIN_FEENOMINATOR = 33;

private cost less than public

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter