Platform: Code4rena
Start Date: 06/12/2022
Pot Size: $36,500 USDC
Total HM: 16
Participants: 119
Period: 3 days
Judge: berndartmueller
Total Solo HM: 2
Id: 189
League: ETH
Rank: 95/119
Findings: 1
Award: $1.34
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: AkshaySrivastav
Also found by: 0x52, 0xA5DF, 0xdeadbeef0x, KingNFT, Madalad, Parth, Soosh, _Adam, adriro, csanuragjain, danyams, eyexploit, gasperpre, gz627, gzeon, hansfriese, hihen, immeas, jadezti, jonatascm, kiki_dev, kree-dotcom, ladboy233, lukris02, lumoswiz, mahdikarimi, minhtrng, nalus, nameruse, obront, reassor, rvierdiiev, seyni, tnevler, wait, yixxas
1.3417 USDC - $1.34
In FixedPriceSale.sol, there is no mechanism to withdraw funds for saleReceiver, if the sales in the buy function never reached the sale for finalId, neither saleReceiver nor feeReceiver will get the their shares of price and funds get locked inside the contract.
if (newId == sale_.finalId) _end(sale);
In case of large NFT collections, there are probaility that only few goes unsale. In that case, surely the creators will decide to go and buy remaining nfts. In order to make sales end and claim their money. Indirectly, creators have to lose some funds here.
It is necessary, there should be a withdrawl mechanism, so that saleReceiver or creator can claim the funds from the sales that have been already made.
#0 - c4-judge
2022-12-12T09:05:05Z
berndartmueller marked the issue as duplicate of #328
#1 - c4-judge
2023-01-02T20:22:58Z
berndartmueller marked the issue as satisfactory