Platform: Code4rena
Start Date: 11/11/2021
Pot Size: $50,000 USDC
Total HM: 9
Participants: 27
Period: 7 days
Judge: alcueca
Total Solo HM: 5
Id: 53
League: ETH
Rank: 11/27
Findings: 3
Award: $1,249.62
🌟 Selected for report: 0
🚀 Solo Findings: 0
1169.9215 USDC - $1,169.92
hack3r-0m
https://github.com/code-423n4/2021-11-nested/blob/main/contracts/FeeSplitter.sol#L264
does not check if there is already a shareholder before creating a new shareholder.
this will cause an issue in findShareHolder since it will return the first shareholder in the array while there are more than one.
#0 - alcueca
2021-12-03T09:36:09Z
Duplicate of #135, taken as principal.
🌟 Selected for report: ye0lde
Also found by: PierrickGT, WatchPug, hack3r-0m, pmerkleplant
13.9113 USDC - $13.91
hack3r-0m
https://github.com/code-423n4/2021-11-nested/blob/main/contracts/NestedFactory.sol#L379
(uint256[] memory amounts, address[] memory tokens)
can be changed to:
(uint256[] memory amounts, )
#0 - adrien-supizet
2021-11-18T12:39:05Z
duplicate #195
#1 - maximebrugel
2021-11-30T16:19:06Z
also duplicate #67 & #66
#2 - alcueca
2021-12-03T09:56:15Z
#195 as the main.
hack3r-0m
https://github.com/code-423n4/2021-11-nested/blob/main/contracts/NestedFactory.sol#L557
should remove address _user since it is unutilized and mark function pure
#0 - adrien-supizet
2021-11-18T12:35:22Z
duplicate #167
#1 - alcueca
2021-12-03T10:14:07Z
Also comments are wrong (#194)