Redacted Cartel contest - halden's results

[G-01] Using unchecked blocks to save gas - Increments in for loop can be unchecked

PirexRewards.sol: 163, 351, 396

[G-02] Superfluous event fields

block.timestamp is added to event information by default so adding them manually wastes gas

PirexRewards.sol: 323-328

emit GlobalAccrue(
                producerToken,
                block.timestamp,
                totalSupply,
                rewards
                );

297 emit UserAccrue(producerToken, user, block.timestamp, balance, rewards);

[G-03] Superfluous event fields for msg.sender

Information about msg.sender can be getted from the transaction, so adding additional field in the event wastes gas

PirexRewards.sol: 121, 143

PirexGmx.sol: 281, 409, 453, 533, 665

AutoPxGlp.sol: 285, 319

AutoPxGmx.sol: 302, 334, 359, 402

PirexERC4626.sol: 75, 94, 117, 143

PirexERC4626.sol: 130

[G-04] Add unchecked {} where the operands can not underflow/overflow because of a previous check

Penalty will never be smaller than assets. AutoPxGlp.sol: 168

AutoPxGmx.sol: 190