Wild Credit contest - hickuphh3's results

Handle

hickuphh3

Vulnerability details

Impact

In getUserTokenAmount(), TickMath.getSqrtRatioAtTick(_tick) is called twice when the position is active (tickLower ≤_tick < tickUpper).

Its value should be saved to avoid a repeat calculation.

Recommended Mitigation Steps

_uint160 oracleTickPrice = TickMath.getSqrtRatioAtTick(_tick);
amount0 = uint(SqrtPriceMath.getAmount0Delta(
  oracleTickPrice,
  TickMath.getSqrtRatioAtTick(tickUpper),
  (int128)(liquidity)
));
amount1 = uint(SqrtPriceMath.getAmount1Delta(
  TickMath.getSqrtRatioAtTick(tickLower),
  oracleTickPrice,
  (int128)(liquidity)
));

Handle

hickuphh3

Vulnerability details

Impact

The following functions can have their visibilities restricted to pure:

• getUserTokenAmount()
• getSqrtPriceX96()
• positionAmounts()

Handle

hickuphh3

Vulnerability details

Impact

In getUserTokenAmount(), I presume that the pool is initialized for testing / development purposes. However, it was not commented out / removed, and becomes unused in the function.

Redundant

IUniswapV3Pool pool =
IUniswapV3Pool(
  PoolAddress.computeAddress(
    positionManager.factory(),
    PoolAddress.PoolKey({
      token0: token0,
      token1: token1,
      fee: fee
    })
  )
);

// (, int24 currentTick, , , , , ) = pool.slot0();

Recommended Mitigation Steps

Remove or uncomment the lines mentioned above.