Fei Protocol contest - hickuphh3's results

Handle

hickuphh3

Vulnerability details

Impact

Looking at the TRIBE token implementation, it would be cheaper to call the transfer() method as opposed to the the transferFrom() method since the latter contains additional logic (Eg. additional SLOAD to fetch the allowance).

Recommended Mitigation Steps

function giveTo(address target, uint256 amount) internal {
  bool check = token1.transfer(target, amount);
	require(check, "erc20 transfer failed");
}

Handle

hickuphh3

Vulnerability details

Impact

The following line

address public constant oracleAddress =
	0xd1866289B4Bd22D453fFF676760961e0898EE9BF; // oracle with caching

is only used in the instantiation of the oracle

IOracle public constant oracle = IOracle(oracleAddress);

The first instantiation can be combined with the second to save gas.

Recommended Mitigation Steps

IOracle public constant oracle = IOracle(0xd1866289B4Bd22D453fFF676760961e0898EE9BF);