Open Dollar - holydevoti0n's results

Lines of code

https://github.com/open-dollar/od-contracts/blob/f4f0246bb26277249c1d5afe6201d4d9096e52e6/src/contracts/gov/ODGovernor.sol#L41

Vulnerability details

Vulnerability Details

The initialVotingDelay is set to 1 block, which means that approximately 12 seconds after creating the proposal, it is already possible to vote. The initialVotingPeriod is set to 15 blocks, which means the proposal will be open for voting in approximately 3 minutes. Governor constructor

Impact

A malicious actor can create a proposal to replace all the contracts called by the governor on Vault721 (and other possible contracts that can be governed by the DAO in the future). By doing this, the attacker has many possibilities to exploit the contract by modifying functions like the transferSAFEOwnership to transfer the user vault/NFT to the malicious address instead of the original destination address.

Tools Used

Manual review

Recommended Mitigation Steps

• Increase the number of blocks for votingDelay to provide users with ample time to read the proposal and understand it clearly before making a hasty decision. A standard delay used by many protocols is 7200 blocks, which is approximately 1 day.
• Extend the initialVotingPeriod to a duration that makes sense for the protocol. Many protocols set it to 50400 blocks, which is roughly equivalent to 1 week.

Assessed type

Governance