Platform: Code4rena
Start Date: 28/11/2022
Pot Size: $192,500 USDC
Total HM: 33
Participants: 106
Period: 11 days
Judge: LSDan
Total Solo HM: 15
Id: 186
League: ETH
Rank: 64/106
Findings: 2
Award: $109.55
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: IllIllI
Also found by: 0x4non, 0x52, 0xAgro, 0xNazgul, 0xSmartContract, 0xackermann, 9svR6w, Awesome, Aymen0909, B2, BRONZEDISC, Bnke0x0, Deekshith99, Deivitto, Diana, Dravee, HE1M, Jeiwan, Kaiziron, KingNFT, Lambda, Mukund, PaludoX0, RaymondFam, Rolezn, Sathish9098, Secureverse, SmartSek, __141345__, ahmedov, ayeslick, brgltd, cccz, ch0bu, chrisdior4, cryptonue, cryptostellar5, csanuragjain, datapunk, delfin454000, erictee, gz627, gzeon, helios, i_got_hacked, ignacio, imare, jadezti, jayphbee, joestakey, kankodu, ksk2345, ladboy233, martin, nadin, nicobevi, oyc_109, pashov, pavankv, pedr02b2, pzeus, rbserver, ronnyx2017, rvierdiiev, shark, unforgiven, xiaoming90, yjrwkk
103.9175 USDC - $103.92
Issue | Instances | |
---|---|---|
[NC-1] | Require parameter verification in NFTFloorOracle.setConfig | 1 |
NFTFloorOracle.setConfig
There is no verification when setting configurations in function NFTFloorOracle.setConfig()
.
If incorrect parameters are set, the system may run into problems. For example, if maxPriceDeviation
is set to less than 100
, NFT prices won't be updated any more since setPrice()
function will always fail.
It is recommended to set appropriate data verifications when updating important configuration parameters.
#0 - c4-judge
2023-01-25T16:45:06Z
dmvt marked the issue as grade-b