Fei Protocol contest - jayjonah8's results

Supporting the creation of $FEI, the stablecoin for DeFi

General Information

Platform: Code4rena

Start Date: 30/11/2021

Pot Size: $30,000 USDC

Total HM: 0

Participants: 21

Period: 3 days

Judge: pauliax

Id: 63

League: ETH

Fei Protocol

Findings Distribution

Researcher Performance

Rank: 12/21

Findings: 1

Award: $76.43

🌟 Selected for report: 1

🚀 Solo Findings: 0

External Links

Code4rena Contest Page Github Contest Repository Github Findings Repository Fei Protocol

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Auditors

Browse

Contests

Browse

Get in touch

Contact Twitter

Findings Information

🌟 Selected for report: jayjonah8

Labels

bug

G (Gas Optimization)

sponsor acknowledged

Awards

73.5785 USDC - $73.58

External Links

Link to GitHub issue

Handle

jayjonah8

Vulnerability details

Impact

Since the variables are hard coded, the constructor function can be removed.

Proof of Concept

https://github.com/code-423n4/2021-11-fei/blob/main/contracts/PegExchanger.sol#L32

Tools Used

Manual code review

#0 - pauliax
2021-12-10T18:43:50Z

Valid optimization.

Findings Information

🌟 Selected for report: robee

Also found by: 0x0x0x, Czar102, GeekyLumberjack, WatchPug, cmichel, defsec, jayjonah8, loop, tqts

Labels

bug

duplicate

G (Gas Optimization)

Awards

2.8506 USDC - $2.85

External Links

Link to GitHub issue

Handle

jayjonah8

Vulnerability details

Impact

Since the party1Accept() function can only be called by the party1Timelock address, it should be marked as external.

Proof of Concept

https://github.com/code-423n4/2021-11-fei/blob/main/contracts/PegExchanger.sol#L89

Tools Used

Manual code review

#0 - elee1766
2021-12-06T03:06:14Z

duplicate #27

#1 - pauliax
2021-12-11T12:22:09Z

A duplicate of #27

Fei Protocol contest - jayjonah8's results

Supporting the creation of $FEI, the stablecoin for DeFi

General Information

Findings Distribution

Researcher Performance

External Links

Gas Report - $76.43

Gas Report - $76.43

🚀 [G-11] constructor should be removed if not used - $73.58

Findings Information

Labels

Awards

External Links

Handle

Vulnerability details

Impact

Proof of Concept

Tools Used

#0 - pauliax2021-12-10T18:43:50Z

[G-17] party1Accept() function should be external - $2.85

Findings Information

Labels

Awards

External Links

Handle

Vulnerability details

Impact

Proof of Concept

Tools Used

#0 - elee17662021-12-06T03:06:14Z

#1 - pauliax2021-12-11T12:22:09Z

#0 - pauliax
2021-12-10T18:43:50Z

#0 - elee1766
2021-12-06T03:06:14Z

#1 - pauliax
2021-12-11T12:22:09Z