Platform: Code4rena
Start Date: 30/11/2021
Pot Size: $30,000 USDC
Total HM: 0
Participants: 21
Period: 3 days
Judge: pauliax
Id: 63
League: ETH
Rank: 17/21
Findings: 1
Award: $26.82
🌟 Selected for report: 0
🚀 Solo Findings: 0
13.4097 USDC - $13.41
jierlich
The takeFrom function checks if the external token0.transferFrom returns true with a require statement. token0 is the RGT token, which has a transferFrom that will only ever return true. Therefore, this check is unnecessary.
Etherscan: https://etherscan.io/address/0xb528e8bb2dcb99cfdea4c28bf44925ef58ab1520#code
Remove the require check from takeFrom and don't assign the local check variable.
#0 - elee1766
2021-12-06T04:46:30Z
#120 #160
#1 - pauliax
2021-12-11T09:21:16Z
A duplicate of #143
13.4097 USDC - $13.41
jierlich
Extra gas is used in the require statement at PegExchange.sol:39 require(msg.sender != address(this), "????");
This function's visibility can be changed from public to external which will guarantee the same outcome while using less gas.
#0 - elee1766
2021-12-06T03:14:01Z
#27
#1 - pauliax
2021-12-10T17:19:48Z
I think "Impact" and "Recommended Mitigation Steps" are about different issues. Based on the title I think this issue is a duplicate of #71