Venus Prime - josephdara's results

Lines of code

https://github.com/code-423n4/2023-09-venus/blob/b11d9ef9db8237678567e66759003138f2368d23/contracts/Tokens/Prime/PrimeLiquidityProvider.sol#L118-L126

Vulnerability details

Impact

The function initializeTokens() is used to initalize tokens y setting their lastAccruedBlock through the internal _initializeToken(). However this is an issue because it does not set the distribution speed which is a necessity for each tokens being initialized. In the _setTokenDistributionSpeed() we see that it accrues the token using a distributionSpeed of zero up to that point, no matter the amount of blocks which have passed. Which is why in the initialize function, it calls both _initializeToken() and _setTokenDistributionSpeed() at the same time .

Proof of Concept

    /**
     * @notice Initialize the distribution of the token
     * @param tokens_ Array of addresses of the tokens to be intialized
     * @custom:access Only Governance
     */
     //@audit initialize TOkens does not initialize the token distribution speed
    function initializeTokens(address[] calldata tokens_) external onlyOwner {
        for (uint256 i; i < tokens_.length; ) {
            _initializeToken(tokens_[i]);

            unchecked {
                ++i;
            }
        }
    }

Tools Used

Manual Review

Recommended Mitigation Steps

Set the distribution speed in the initializeTokens() function to avoid loss of accural blocks.

Assessed type

Other