FactoryDAO contest - juicy's results

contracts/PermissionlessBasicPoolFactory.sol :214 the require() function accepts a case in which recept.owner == msg.sender OR block.timestamp > pool.endTime - based on the error message it is unclear whether this is the intended behaviour or if the function should, instead of ||, use && :282 note this does not support tokens with other than 18 decimals

contracts/FixedPricePassThruGate.sol :15 suggest to rename the variable as weiCost for clarity (e.g. on row 48, it is compared against msg.value which is denominated in wei)

contracts/SpeedBumpPriceGate.sol :49 suggest to rename the variable as weiCost for clarity

contracts/PermissionlessBasicPoolFactory.sol :112 the require() function refunds any left over gas to the user in case it reverts. Calling the function before setting the variables will save the user gas in case the function reverts. I suggest moving the function to line 103. :185 instead of testing the pool.totalDepositsWei < pool.maximumDepositsWei case each time the deposit() function is ran, I suggest to save the pool state as a boolean, e.g. "bool isFull" which is set to FALSE at initiation and to true within the if loop of line 186

contracts/FixedPricePassThruGate.sol :51 remove if qualification (is there any reason for the msg.value to be non-zero if it passes the require() on row 48?)

contracts/SpeedBumpPriceGate.sol :55 change if evaluation from < to <= to save on computations in the case where priceFloor and lastPrice - decay are the same :77 remove if qualification (is there any reasons for the msg.value to be non-zero if it passes require() on row 67?)