Platform: Code4rena
Start Date: 25/01/2023
Pot Size: $36,500 USDC
Total HM: 11
Participants: 173
Period: 5 days
Judge: kirk-baird
Total Solo HM: 1
Id: 208
League: ETH
Rank: 101/173
Findings: 1
Award: $17.20
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: CodingNameKiki
Also found by: 0x1f8b, 0x4non, 0x5rings, 0xAgro, 0xMirce, 0xRobocop, 0xSmartContract, 0xackermann, AkshaySrivastav, ArmedGoose, Aymen0909, BClabs, Breeje, Dewaxindo, Diana, HollaDieWaldfee, IceBear, IllIllI, Iurii3, Josiah, Krayt, PaludoX0, Phenomana, PrasadLak, RaymondFam, Rolezn, SaeedAlipoor01988, SaharDevep, SleepingBugs, adriro, arialblack14, bin2chen, brevis, btk, carlitox477, carrotsmuggler, catellatech, chaduke, chrisdior4, cryptonue, cryptostellar5, csanuragjain, ddimitrov22, fellows, glcanvas, halden, hl_, horsefacts, jat, joestakey, kenta, libratus, lukris02, luxartvinsec, manikantanynala97, martin, matrix_0wl, nadin, nicobevi, oberon, peanuts, prestoncodes, rbserver, sakshamguruji, sashik_eth, sayan, seeu, thekmj, tnevler, trustindistrust, tsvetanovv, xAriextz, zadaru13, zaskoh
17.196 USDC - $17.20
startTime_ must be earlier than endTime_. A validation for it is missing in createQuest.
Add a new validation for the startTime_ and endTime_. if (startTime_ >= endTime_) revert InvalidQuestDuration:
You need to deploy the contract again if the input account_ is an empty address because no account has the DEFAULT_ADMIN_ROLE and can not execute the grantRole.
Add the validation if the input account_ is empty or not.
if (account_ == address(0)) revert AddressZeroNotAllowd();
Replace remave with remove
#0 - kirk-baird
2023-02-06T09:06:57Z
All valid issues but insufficient quantity to qualify for grade-b
#1 - c4-judge
2023-02-06T09:07:03Z
kirk-baird marked the issue as grade-c
#2 - kirk-baird
2023-02-16T06:35:08Z
Upgrading to grade-b due to #505
#3 - c4-judge
2023-02-16T06:35:12Z
kirk-baird marked the issue as grade-b