Platform: Code4rena
Start Date: 15/10/2021
Pot Size: $35,000 USDC
Total HM: 4
Participants: 10
Period: 4 days
Judge: GalloDaSballo
Total Solo HM: 2
Id: 38
League: ETH
Rank: 7/10
Findings: 2
Award: $61.52
🌟 Selected for report: 1
🚀 Solo Findings: 0
🌟 Selected for report: loop
61.5157 USDC - $61.52
loop
The withdraw function in IdentityFactory.sol is declared as public but can be external since it is not used internally.
Saves some gas in case it ever needs to be called.
https://github.com/code-423n4/2021-10-ambire/blob/main/contracts/IdentityFactory.sol#L52
#0 - Ivshti
2021-10-19T16:03:25Z
#1 - GalloDaSballo
2021-10-24T22:41:42Z
Any function not used internally is best set to external
Here's a neat SO discussion that shows some of the gas math: https://ethereum.stackexchange.com/questions/19380/external-vs-public-best-practices
#2 - GalloDaSballo
2021-10-24T22:41:51Z
The sponsor has applied the recommendation