Platform: Code4rena
Start Date: 09/02/2024
Pot Size: $60,500 USDC
Total HM: 17
Participants: 283
Period: 12 days
Judge:
Id: 328
League: ETH
Rank: 67/283
Findings: 1
Award: $111.68
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: abhishek_thaku_r
Also found by: 0xAlix2, 0xDetermination, 0xShitgem, Draiakoo, Fulum, Greed, MrPotatoMagic, PoeAudits, Tychai0s, ahmedaghadi, alexzoid, dimulski, fnanni, givn, iamandreiski, immeas, kartik_giri_47538, kiqo, klau5, korok, ktg, maxim371, offside0011, pontifex, sashik_eth, stakog, swizz, yotov721
111.676 USDC - $111.68
Using uint8 instead of uint256 in Solidity has implications regarding storage efficiency, range of values, and potential for overflow. This means only the first 256 tokenIDs can reroll which is not the intended logic
https://github.com/code-423n4/2024-02-ai-arena/blob/f2952187a8afc44ee6adc28769657717b498b7d4/src/FighterFarm.sol#L370
https://github.com/code-423n4/2024-02-ai-arena/blob/f2952187a8afc44ee6adc28769657717b498b7d4/src/FighterFarm.sol#L370-L391
Manual Review
change from uint8 to uint256 for tokenIDs
Error
#0 - c4-pre-sort
2024-02-22T02:21:49Z
raymondfam marked the issue as sufficient quality report
#1 - c4-pre-sort
2024-02-22T02:21:55Z
raymondfam marked the issue as duplicate of #68
#2 - c4-judge
2024-03-05T02:00:08Z
HickupHH3 marked the issue as satisfactory