Tribe Turbo contest - nascent's results

[L-01] Remove Optimized Unchecked Operations

Severity: Medium Likelihood: Low Status: {Not Submitted} Scopes

• TurboSafe:boost()
• TurboSafe:less()
• TurboSafe:slurp()
• TurboMaster:onSafeBoost()
• TurboMaster:onSafeLess()
• TurboMaster:onSafeSlurp()

Unchecked operations on balance state variables expose attack surfaces to create inconsistent state. Consider enforcing safe arithmetic by removing the unchecked gas optimizations.

[L-02] Inconsistent Fee Percent Denomination

Severity: Medium Likelihood: Low Status: {Not Submitted} Scope: TurboClerk

The fee percent managed by clerk is denominated with 1e18 decimals. But when the fee is used by composed modules, it expects the vault's asset to use a WAD denomination (as used in FixedPointMathLib).

This works for fei calculations, but TurboSafe accepts any ERC20 compliant asset. Thus, ERC20s can effectively avoid Turbo fees by specifying a large decimal count.

Recommendation: TurboClerk should denominate safe and collateral fee percents in the ERC20 decimal count instead of using an upper bounds of 1e18.

[L-04] Extend TurboRouter Authentication

Severity: Low Likelihood: Low Status: {Not Submitted} Scope: TurboRouter:authenticate

TurboRouter authenticates TurboSafe interactions solely by the safe's authority owner rather than permissioning on the canonical canCall Authority pattern defined in solmate. The authenticate modifier could accept a function signature to validate if the sender can call the function (signature) on the given target.

Recommendation: Authenticate on owner or if the msg.sender can call the given function (signature).

[L-00] slurp SLOAD Gas Optimization

Severity: Gas Optimization Likelihood: High Status: {Not Submitted} Scope: slurp()

There are two sloads of getTotalFeiBoostedForVault[vault] that can be gas golfed using an mload to reduce gas by 100 - 3.

[L-03] save SLOAD Gas Optimization

Severity: Gas Optimization Likelihood: Medium Status: {Not Submitted} Scope: save()

There are two calls of pool.oracle() that can be gas golfed using an mload to reduce gas by 100 - 3.