Platform: Code4rena
Start Date: 18/11/2021
Pot Size: $50,000 USDC
Total HM: 18
Participants: 26
Period: 7 days
Judge: leastwood
Total Solo HM: 12
Id: 54
League: ETH
Rank: 21/26
Findings: 2
Award: $60.68
🌟 Selected for report: 1
🚀 Solo Findings: 0
nathaniel
Public functions in Unlock.sol can be made external to save on gas fees.
addLockTemplate, createLock, upgradeLock, recordKeyPurchase, initialize, initializeProxyAdmin.
https://github.com/code-423n4/2021-11-unlock/blob/main/smart-contracts/contracts/Unlock.sol
#0 - 0xleastwood
2022-01-17T08:52:08Z
Duplicate of #196
🌟 Selected for report: nathaniel
nathaniel
The freeTrialLength == 0 seems to be a redundant check as if true, then timeRemaining + freeTrialLength < expirationDuration would be true as well since timeRemaining should always be less than expirationDuration.
manual
remove the freeTrialLength == 0 check.