Open Dollar - niki's results

Lines of code

https://github.com/open-dollar/od-contracts/blob/f4f0246bb26277249c1d5afe6201d4d9096e52e6/src/contracts/proxies/actions/CommonActions.sol#L91

Vulnerability details

Impact

the protocol will always revert if your collateral token is with more decimals than 18

Proof of Concept

e.g. lets say we use erc20 token - YAM-V2 in the calculation 18 - token.decimals will equal to -6 which will revert.

Tools Used

manual

Recommended Mitigation Steps

you can make check if the decimals are greater than 18, and if they are the math can be : uint256 _wei = _wad /10 /(10 ** (token.decimals - 18));

Assessed type

Decimal