Ondo Finance - ohm's results

Institutional-Grade Finance. On-Chain. For Everyone.

General Information

Platform: Code4rena

Start Date: 01/09/2023

Pot Size: $36,500 USDC

Total HM: 4

Participants: 70

Period: 6 days

Judge: kirk-baird

Id: 281

League: ETH

Ondo Finance

Findings Distribution

Researcher Performance

Rank: 66/70

Findings: 1

Award: $7.08

🌟 Selected for report: 0

🚀 Solo Findings: 0

Awards

7.08 USDC - $7.08

Labels

bug
grade-b
low quality report
QA (Quality Assurance)
Q-20

External Links

ACCOUNT ADDRESS WILL NOT BE ZERO

function _burnShares( address _account, uint256 _sharesAmount ) internal whenNotPaused returns (uint256) { require(_account != address(0), "BURN_FROM_THE_ZERO_ADDRESS"); _beforeTokenTransfer(_account, address(0), _sharesAmount); uint256 accountShares = shares[_account]; require(_sharesAmount <= accountShares, "BURN_AMOUNT_EXCEEDS_BALANCE"); uint256 preRebaseTokenAmount = getRUSDYByShares(_sharesAmount); totalShares -= _sharesAmount; shares[_account] = accountShares - _sharesAmount; // ISSUE ----> = postRebaseTokenAmount is not getting the post rusdy tokens //Because _sharesAmount is not updating. uint256 postRebaseTokenAmount = getRUSDYByShares(_sharesAmount);

In the above function there is no possibility of becoming the address is 0.So we can avoid the require statement .

require(_account != address(0), "BURN_FROM_THE_ZERO_ADDRESS");

#0 - c4-pre-sort

2023-09-08T08:18:17Z

raymondfam marked the issue as low quality report

#1 - c4-judge

2023-09-21T10:06:46Z

kirk-baird marked the issue as grade-c

#2 - c4-judge

2023-09-23T00:44:49Z

kirk-baird marked the issue as grade-b

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter