Frankencoin - p0wd3r's results

A decentralized and fully collateralized stablecoin.

General Information

Platform: Code4rena

Start Date: 12/04/2023

Pot Size: $60,500 USDC

Total HM: 21

Participants: 199

Period: 7 days

Judge: hansfriese

Total Solo HM: 5

Id: 231

League: ETH

Frankencoin

Findings Distribution

Researcher Performance

Rank: 166/199

Findings: 1

Award: $22.60

QA:
grade-b

🌟 Selected for report: 0

🚀 Solo Findings: 0

The withdraw function will fail when extracting non-standard ERC20 tokens.

Position.sol L253

/** * Withdraw any ERC20 token that might have ended up on this address. * Withdrawing collateral is subject to the same restrictions as withdrawCollateral(...). */ function withdraw(address token, address target, uint256 amount) external onlyOwner { if (token == address(collateral)){ withdrawCollateral(target, amount); } else { IERC20(token).transfer(target, amount); } }

Although the document states that the collateral needs to be reverted in case of a failed transfer, this function also has the ability to extract non-collateral tokens, which requires safeTransfer to ensure availability.

#0 - c4-pre-sort

2023-04-26T17:02:47Z

0xA5DF marked the issue as low quality report

#1 - 0xA5DF

2023-04-26T17:02:57Z

Single NC + automated findings

#2 - c4-judge

2023-05-16T03:04:40Z

hansfriese marked the issue as grade-c

#3 - c4-judge

2023-05-18T07:39:18Z

hansfriese marked the issue as grade-b

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter