BadgerDAO Zaps contest - pants's results

Handle

pants

Vulnerability details

Vulnerability details

At Zap.sol init function you have the for loop pattern:

for (uint256 i = 0; i < array.length; i++) { // do something with array[i] }

In such for loops, the `array.length` is read on every iteration, instead of caching it once in a local variable and read it again using the local variable.

## Impact
Storage reads are much more expensive than reading local variables. Memory and calldata reads are a bit more expensive than reading local variables.

## Tool Used
Manual code review.

## Recommended Mitigation Steps
Read these values from storage / memory / calldata once, cache them in local variables and then read them again using the local variables. For example:

uint256 length = array.length; for (uint256 i = 0; i < length; i++) { // do something with array[i] }

Handle

pants

Vulnerability details

The function deposit(uint256[4] calldata _amounts) public whenNotPaused could be set external instead of public. (in IbbtcVaultZap)

Handle

pants

Vulnerability details

uint initial value is 0. Therefore the assignment uint i = 0 is unnecessary (Zap.sol line 70)