Covalent contest - pauliax's results

Handle

pauliax

Vulnerability details

Impact

Functions that are never called by the contract itself and are meant to be invoked only from the outside, do not need to be 'public' and could be marked as 'external'.

Handle

pauliax

Vulnerability details

Impact

function addValidator should validate that commissionRate < divider. As seen in setValidatorCommissionRate, commissionRate cannot exceed 100% (divider), however this is not ensured in function addValidator.

Recommended Mitigation Steps

require(commissionRate < divider, "Rate must be less than 100%");

Handle

pauliax

Vulnerability details

Impact

Using the unchecked keyword to avoid redundant arithmetic checks and save gas when an underflow/overflow cannot happen. E.g. 'unchecked' can be applied in the following lines of code since there are require statements before to ensure the arithmetic operations would not cause an integer underflow or overflow: require(rewardsLocked >= amount, "Amount is greater than available"); rewardsLocked -= amount; or

uint128 commissionLeftOver = amount < v.commissionAvailableToRedeem ? v.commissionAvailableToRedeem - amount : 0;

Consider if you want to apply this keyword and then carefully select where it is safe to do this.