LSD Network - Stakehouse contest - peanuts's results

A permissionless 3 pool liquid staking solution for Ethereum.

General Information

Platform: Code4rena

Start Date: 11/11/2022

Pot Size: $90,500 USDC

Total HM: 52

Participants: 92

Period: 7 days

Judge: LSDan

Total Solo HM: 20

Id: 182

League: ETH

Stakehouse Protocol

Findings Distribution

Researcher Performance

Rank: 75/92

Findings: 1

Award: $52.03

QA:

grade-b

🌟 Selected for report: 0

🚀 Solo Findings: 0

External Links

Code4rena Contest Page Github Contest Repository Github Findings Repository Stakehouse Protocol

Findings Information

🌟 Selected for report: 0xSmartContract

Also found by: 0x4non, 0xNazgul, 0xRoxas, 0xdeadbeef0x, 0xmuxyz, 9svR6w, Awesome, Aymen0909, B2, Bnke0x0, CloudX, Deivitto, Diana, Franfran, IllIllI, Josiah, RaymondFam, ReyAdmirado, Rolezn, Sathish9098, Secureverse, SmartSek, Trust, Udsen, a12jmx, aphak5010, brgltd, bulej93, c3phas, ch0bu, chaduke, chrisdior4, clems4ever, cryptostellar5, datapunk, delfin454000, fs0c, gogo, gz627, hl_, immeas, joestakey, lukris02, martin, nogo, oyc_109, pashov, pavankv, peanuts, pedr02b2, rbserver, rotcivegaf, sahar, sakman, shark, tnevler, trustindistrust, zaskoh, zgo

Awards

52.0338 USDC - $52.03

Labels

bug

grade-b

QA (Quality Assurance)

Q-04

External Links

Link to GitHub issue

[L-01] Transfer of Ownership should be a two-step process
[N-01] if( should be if ( to match other lines in the file
[N-02] Use neutral terms instead of sensitive ones
[N-03] Lock floating pragma for non-library / interface contracts
[N-04] Open Todos
[N-05] 2**<N>-1 should be re-written as type(uint<n>).max

[L-01] Transfer of Ownership should be a two-step process

When transferring DAO contract, make sure the process is two-step to prevent accidental transfer errors

https://github.com/code-423n4/2022-11-stakehouse/blob/4b6828e9c807f2f7c569e6d721ca1289f7cf7112/contracts/liquid-staking/LiquidStakingManager.sol#L239-L246

[N-01] if( should be if ( to match other lines in the file

For standardization purposes

for( https://github.com/code-423n4/2022-11-stakehouse/blob/4b6828e9c807f2f7c569e6d721ca1289f7cf7112/contracts/liquid-staking/LiquidStakingManager.sol#L392 https://github.com/code-423n4/2022-11-stakehouse/blob/4b6828e9c807f2f7c569e6d721ca1289f7cf7112/contracts/liquid-staking/LiquidStakingManager.sol#L465

for ( https://github.com/code-423n4/2022-11-stakehouse/blob/4b6828e9c807f2f7c569e6d721ca1289f7cf7112/contracts/liquid-staking/LiquidStakingManager.sol#L538 https://github.com/code-423n4/2022-11-stakehouse/blob/4b6828e9c807f2f7c569e6d721ca1289f7cf7112/contracts/liquid-staking/LiquidStakingManager.sol#L587

[N-02] Use neutral terms instead of sensitive ones

Use allowlist rather than whitelist

https://github.com/code-423n4/2022-11-stakehouse/blob/4b6828e9c807f2f7c569e6d721ca1289f7cf7112/contracts/liquid-staking/LiquidStakingManager.sol#L265-L284

[N-03] Lock floating pragma for non-library / interface contracts

https://github.com/code-423n4/2022-11-stakehouse/blob/4b6828e9c807f2f7c569e6d721ca1289f7cf7112/contracts/liquid-staking/LiquidStakingManager.sol#L3

[N-04] Open Todos

Code is not closed properly

https://github.com/code-423n4/2022-11-stakehouse/blob/4b6828e9c807f2f7c569e6d721ca1289f7cf7112/contracts/syndicate/Syndicate.sol#L195

[N-05] 2**<N>-1 should be re-written as type(uint<n>).max

https://github.com/code-423n4/2022-11-stakehouse/blob/4b6828e9c807f2f7c569e6d721ca1289f7cf7112/contracts/liquid-staking/LiquidStakingManager.sol#L870

#0 - c4-judge
2022-11-29T15:18:44Z

dmvt marked the issue as grade-b

LSD Network - Stakehouse contest - peanuts's results

A permissionless 3 pool liquid staking solution for Ethereum.

General Information

Findings Distribution

Researcher Performance

External Links

[Q-04] QA Report - $52.03

Findings Information

Awards

Labels

External Links

Table of Contents

[L-01] Transfer of Ownership should be a two-step process

[N-01] if( should be if ( to match other lines in the file

[N-02] Use neutral terms instead of sensitive ones

[N-03] Lock floating pragma for non-library / interface contracts

[N-04] Open Todos

[N-05] 2**<N>-1 should be re-written as type(uint<n>).max

#0 - c4-judge2022-11-29T15:18:44Z

#0 - c4-judge
2022-11-29T15:18:44Z