Venus Protocol Isolated Pools - peritoflores's results

Earn, Borrow & Lend on the #1 Decentralized Money Market on the BNB Chain

General Information

Platform: Code4rena

Start Date: 08/05/2023

Pot Size: $90,500 USDC

Total HM: 17

Participants: 102

Period: 7 days

Judge: 0xean

Total Solo HM: 4

Id: 236

League: ETH

Venus Protocol

Findings Distribution

Researcher Performance

Rank: 58/102

Findings: 1

Award: $66.59

🌟 Selected for report: 0

🚀 Solo Findings: 0

Awards

66.5871 USDC - $66.59

Labels

bug
3 (High Risk)
satisfactory
upgraded by judge
duplicate-320

External Links

Lines of code

https://github.com/code-423n4/2023-05-venus/blob/8be784ed9752b80e6f1b8b781e2e6251748d0d7e/contracts/WhitePaperInterestRateModel.sol#L17

Vulnerability details

Impact

Incorrect calculation of critical parameters like baseRatePerBlock.

Proof of Concept

The constant blocksPerYear is incorrectly set

uint256 public constant blocksPerYear = 2102400; // @audit 15 seconds per block

However, for Binance Smart Chain the blocks are being produced every 3 seconds.

[-] uint256 public constant blocksPerYear = 2102400; [+] uint256 public constant blocksPerYear = 5 * 2102400;

Assessed type

Error

#0 - c4-judge

2023-05-16T09:21:37Z

0xean marked the issue as duplicate of #559

#1 - c4-judge

2023-06-05T14:02:51Z

0xean marked the issue as satisfactory

#2 - c4-judge

2023-06-05T14:38:22Z

0xean changed the severity to 2 (Med Risk)

#3 - c4-judge

2023-06-05T14:38:32Z

0xean changed the severity to 3 (High Risk)

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter