Dopex - piyushshukla's results

Lines of code

https://github.com/code-423n4/2023-08-dopex/blob/eb4d4a201b3a75dd4bddc74a34e9c42c71d0d12f/contracts/perp-vault/PerpetualAtlanticVault.sol#L576

Vulnerability details

Impact

roundUp function results in incorrect rounding behavior when the remainder is greater than the _strike value. This issue may lead to incorrect calculations

Proof of Concept

The roundUp function in the contract does not correctly round up the _strike value when the remainder is greater than _strike. This leads to incorrect results in cases where the remainder is greater than _strike

https://github.com/code-423n4/2023-08-dopex/blob/eb4d4a201b3a75dd4bddc74a34e9c42c71d0d12f/contracts/perp-vault/PerpetualAtlanticVault.sol#L576C3-L584C1

function roundUp(uint256 _strike) public view returns (uint256 strike) { uint256 remainder = _strike % roundingPrecision; if (remainder == 0) { return _strike; } else { return _strike - remainder + roundingPrecision; } }

Tools Used

mannual

Recommended Mitigation Steps

Modify the roundUp function to handle cases where the remainder is greater than _strike by adding the difference between roundingPrecision and the remainder to _strike

Assessed type

Math