Platform: Code4rena
Start Date: 14/10/2021
Pot Size: $50,000 USDC
Total HM: 3
Participants: 14
Period: 7 days
Judge: 0xean
Total Solo HM: 3
Id: 37
League: ETH
Rank: 5/14
Findings: 2
Award: $2,431.97
🌟 Selected for report: 2
🚀 Solo Findings: 0
🌟 Selected for report: pmerkleplant
2272.7273 USDC - $2,272.73
pmerkleplant
If initInterestRate in the TempusPool's constructor is given as 0,
no funds can be withdrawn as getRedemptionAmounts() always panic errors with
division by 0 (link).
It should be stated in the constructor's specs that initInterestRate should
not be 0.
#0 - mijovic
2021-10-19T09:45:44Z
This is irregular state of the contract, so we will add require that checks if initial rate is not 0
#1 - mijovic
2021-10-21T08:34:17Z
🌟 Selected for report: pmerkleplant
159.2357 USDC - $159.24
pmerkleplant
The protocolName variables in the protocol-specific TempusPools are set as
immutable but could be set as constant.
#0 - mijovic
2021-10-19T13:14:25Z
Well, constant is not cheaper to use. immutable Is cheaper if it is used in multiple places.
However, since this is used off-chain only, we are probably fine with both immutable and constant
#1 - mijovic
2021-10-21T08:25:46Z
Ended up doing this fix https://github.com/tempus-finance/tempus-protocol/pull/363
#2 - 0xean
2021-10-28T17:49:52Z
marking as a gas optimization.