Axelar Network - qpzm's results

Lines of code

https://github.com/code-423n4/2023-07-axelar/blob/1e2acdbd9aa992d10e68f35647db9f080a169252/contracts/interchain-governance-executor/InterchainProposalExecutor.sol#L76

Vulnerability details

Impact

_executeProposal cannot send ether if call.value is not zero.

(bool success, bytes memory result) = call.target.call{ value: call.value }(call.callData);

https://github.com/code-423n4/2023-07-axelar/blob/1e2acdbd9aa992d10e68f35647db9f080a169252/contracts/interchain-governance-executor/InterchainProposalExecutor.sol#L76

Proof of Concept

I add one it block after test/interchain-governance-executor/InterchainProposalExecutor.js#26.

describe('_execute', function () {
  it('cannot receive ether to send in _executeProposal', async function () {
    await signer.sendTransaction({
      to: executor.address,
      value: ethers.utils.parseEther('1')
    });
  });

$ yarn hardhat test --grep "cannot receive ether to send in _executeProposal"
1) Interchain Proposal Executor
       _execute
         cannot receive ether to send in _executeProposal:
     Error: cannot estimate gas; transaction may fail or may require manual gas limit [ See: https://links.ethers.org/v5-errors-UNPREDICTABLE_GAS_LIMIT ] (reason="Transaction reverted: function selector was not recognized and there's no fallback nor receive function",

Tools Used

Manual review.

Recommended Mitigation Steps

Add receive() in InterchainProposalExecutor.sol.

+ receive() external payable {}

Assessed type

ETH-Transfer