Platform: Code4rena
Start Date: 27/01/2022
Pot Size: $75,000 USDT
Total HM: 6
Participants: 29
Period: 7 days
Judge: leastwood
Total Solo HM: 6
Id: 72
League: ETH
Rank: 5/29
Findings: 2
Award: $4,930.14
🌟 Selected for report: 2
🚀 Solo Findings: 1
🌟 Selected for report: robee
4882.8125 USDT - $4,882.81
robee
The following functions are not payable but uses msg.value - therefore the function must be payable. This can lead to undesired behavior.
LPool.sol, addReserves should be payable since using msg.value
#0 - 0xleastwood
2022-02-19T10:53:17Z
Nice find! The warden has identified a function which is missing the payable keyword. Preventing any users from adding reserves using native ether.
28.2591 USDT - $28.26
robee
Inline those functions
OpenLevV1.sol, verifyCloseBefore OpenLevV1.sol, flashBuy UniV3Dex.sol, calcAvgPrices GovernorAlpha.sol, getChainId UniV3Dex.sol, uniV3GetPrice LPool.sol, getSupplyRateInternal UniV2Dex.sol, toUint32 GovernorAlpha.sol, _queueOrRevert
#0 - ColaM12
2022-01-27T11:33:36Z
Duplicate to #24
#1 - 0xleastwood
2022-02-21T02:00:35Z
Duplicate of #26
🌟 Selected for report: robee
Also found by: Dravee, mics, sirhashalot
19.0749 USDT - $19.07
robee
The following require messages are of length more than 32 and we think are short enough to short them into exactly 32 characters such that it will be placed in one slot of memory and the require function will cost less gas. The list:
Solidity file: XOLE.sol, In line 254, Require message length to shorten: 38, The message: Can only lock until time in the future Solidity file: XOLE.sol, In line 268, Require message length to shorten: 36, The message: Cannot add to expired lock. Withdraw Solidity file: GovernorAlpha.sol, In line 159, Require message length to shorten: 40, The message: GovernorAlpha::propose: too many actions Solidity file: Adminable.sol, In line 37, Require message length to shorten: 34, The message: only pendingAdmin can accept admin