Kelp DAO | rsETH - rumen's results

GAS 01 - NodeDelegator.sol:110 -> cache IStrategy(strategies[i]): (Saves 118 gas)

110: assets[i] = address(IStrategy(strategies[i]).underlyingToken());
111: assetBalances[i] = IStrategy(strategies[i]).userUnderlyingView(address(this));

Suggested edit:

IStrategy strategy = IStrategy(strategies[i]);
assets[i] = address(strategy.underlyingToken());
assetBalances[i] = strategy.userUnderlyingView(address(this));

GAS 02 - LRTDepositPool.sol:83 -> cache nodeDelegatorQueue[i] as a variable (Saves 837 gas)

83: assetLyingInNDCs += IERC20(asset).balanceOf(nodeDelegatorQueue[i]);
84: assetStakedInEigenLayer += INodeDelegator(nodeDelegatorQueue[i]).getAssetBalance(asset);

Suggested edit:

address currentNdc = nodeDelegatorQueue[i];
assetLyingInNDCs += IERC20(asset).balanceOf(nodeDelegatorQueue[i]);
assetStakedInEigenLayer += INodeDelegator(nodeDelegatorQueue[i]).getAssetBalance(asset);

GAS 03 - LRTOracle.sol:68 -> directly use getAssetPrice(asset) and ILRTDepositPool(lrtDepositPoolAddr).getTotalAssetDeposits(asset) instead of declaring variables (assetER, totalAssetAmt) which are used once -> saves 48 gas on average

67: address asset = supportedAssets[asset_idx];
68: uint256 assetER = getAssetPrice(asset);

70: uint256 totalAssetAmt = ILRTDepositPool(lrtDepositPoolAddr).getTotalAssetDeposits(asset);
71: totalETHInPool += totalAssetAmt * assetER;

Suggested edit:

address asset = supportedAssets[asset_idx];
            
totalETHInPool += ILRTDepositPool(lrtDepositPoolAddr).getTotalAssetDeposits(asset) * getAssetPrice(asset);