Platform: Code4rena
Start Date: 29/04/2021
Pot Size: $50,000 USDC
Total HM: 9
Participants: 10
Period: 2 days
Judge: Joseph Delong
Total Solo HM: 9
Id: 6
League: ETH
Rank: 4/10
Findings: 2
Award: $6,684.49
🌟 Selected for report: 3
🚀 Solo Findings: 1
🌟 Selected for report: s1m0
s1m0
The getPrice() (https://github.com/code-423n4/2021-04-redacted/blob/main/Beebots.sol#L334) return 0 after the sale ended and SALE_LIMIT - numSales nft can be minted for free.
Manual analysis
Without documentation i'm not sure if it's the expected behaviour or not. If it's not you could revert instead of returning 0. If it's expected behaviour it's possible to create a smartContract and claim all the remaining nft frontrunning the normal users.
🌟 Selected for report: s1m0
s1m0
on line 650 require(amount <= ethBalance[msg.sender]); is not needed because it's implicitly checked when making the subtraction in the following line
Manual analysis
Remove the require()
#0 - dangerousfood
2021-05-25T00:01:32Z
Fantastic catch imo
🌟 Selected for report: s1m0
s1m0
The function pauseMarket() on line 230 can be optimized.
Manual analysis
Don't use an argument and set marketPaused = !marketPaused