Fei Protocol contest - sabtikw's results

Handle

sabtikw

Vulnerability details

initializing storage variables with default values is unnecessary and increases the gas required for deployment however it might be negligible

TRIBERagequit.sol : storage variables : uint256 public expirationBlock = 0; -> uint256 public expirationBlock uint256 public token1OutBase = 0; -> uint256 public token1OutBase; bool public party0Accepted = false; -> bool public party0Accepted; bool public party1Accepted = false -> bool public party1Accepted; bool public init = false -> bool public init ; bytes32 public merkleRoot = 0x0000000000000000000000000000000000000000000000000000000000000000; --> bytes32 public merkleRoot;

this should reduce deployment gas from 843911 -> 836833

PegExchanger.sol : bool public party0Accepted = false; -> bool public party0Accepted; bool public party1Accepted = false; -> bool public party1Accepted; uint256 public expirationBlock = 0; -> uint256 public expirationBlock;