Platform: Code4rena
Start Date: 04/02/2022
Pot Size: $30,000 USDC
Total HM: 3
Participants: 37
Period: 3 days
Judge: leastwood
Id: 84
League: ETH
Rank: 28/37
Findings: 1
Award: $63.90
🌟 Selected for report: 0
🚀 Solo Findings: 0
63.9043 USDC - $63.90
samruna
https://github.com/code-423n4/2022-02-badger-citadel/blob/main/contracts/TokenSaleUpgradeable.sol#L6 No need import ERC20Upgradeable if SafeERC20Upgradeable is also imported
https://github.com/code-423n4/2022-02-badger-citadel/blob/main/contracts/TokenSaleUpgradeable.sol#L16 Redundant to use both contracts
https://github.com/code-423n4/2022-02-badger-citadel/blob/main/contracts/TokenSaleUpgradeable.sol#L185 https://github.com/code-423n4/2022-02-badger-citadel/blob/main/contracts/TokenSaleUpgradeable.sol#L202 Since you are using safeTransferFrom, no need to emit another event. This is using double gas fees
https://github.com/code-423n4/2022-02-badger-citadel/blob/main/contracts/TokenSaleUpgradeable.sol#L330 Add empty check for guestList
https://github.com/code-423n4/2022-02-badger-citadel/blob/main/contracts/TokenSaleUpgradeable.sol#L340 Add zero check to tokenLimit
#0 - GalloDaSballo
2022-02-14T14:00:17Z
I think these findings should be downgraded to non-critical, but all in all valid