SIZE contest - shark's results

Use delete to reset variables

The reason why is because delete keyword better communicates the intention of what you are trying to do.

For example:

File: SizeSealed.sol Line 404

a.data.seller = address(0);

The above could use the delete keyword like so:

delete a.data.seller; // resets to default value, for type address that would be address(0)

Here are the rest of the instances:

File: SizeSealed.sol Line 347 File: SizeSealed.sol Line 379 File: SizeSealed.sol Line 432 File: SizeSealed.sol Line 435

Revert as early as possible

Conditional checks should appear as early as possible in a function. If a revert were to occur, it would avoid incurring extra gas on code coming after the checks.

The following lines of code can be executed before updating ebid:

File: SizeSealed.sol Line 155-159

Typos

File: SizeSealed.sol (Line 112, Line 211, Line 412, Line 431)

      /// @audit Change "runnning" to "running"
112:  /// @notice Bid on a runnning auction

      /// @audit To be consistent, only use one spelling of the word.
      /// @audit "Finalises"
211:  /// @notice Finalises an auction by revealing all bids

      /// @audit "finalised"
412:  /// @dev Transfers `quoteToken` back to bidder and prevents bid from being finalised

      /// @audit Change "futher" to "further"
431:  // Prevent any futher access to this EncryptedBid