Rigor Protocol contest - sikorico's results

[QA 01] Use safeTransfer instead transfer in the following locations

Proof of concept:

[HomeFiProxy.sol#L155](https://github.com/code-423n4/2022-08-rigor/tree/main/contracts/HomeFiProxy.sol#L155)

[QA 02] Mismatched solidity versions

The code is compiled with more than one solidity version which can cause undesired behavior.

[QA 03] Use two steps verification for the following contracts

Proof of concept:

• HomeFiProxy.sol

[QA 04] Timelock is missing for the following functions

Proof of concept:

• HomeFi.sol#L205
• Project.sol#L333
• HomeFi.sol#L140

[QA 05] Magic number, consider using named constant instead.

Proof of concept:

• Community.sol#L392
• Community.sol#L684
• Community.sol#L689

[QA 06] Both return statement and named return

For readability purposes consider having one of the two return options (for the following functions)

Proof of concept:

• HomeFi.sol#L308
• Project.sol#L721

[QA 07] Not emitted event for state changes

Proof of concept:

• Project.sol#L98
• Community.sol#L107
• HomeFi.sol#L205
• HomeFi.sol#L107
• DebtToken.sol#L48

[QA 08] Remove the name from the following unused function parameters

Proof of concept:

• Community.sol#L291

GAS REPORT

[GAS 00] Cache the array size for the following loops over array

Proof of concept:

• Project.sol#L602

[GAS 01] Unnecessary caching of msg.sender

Proof of concept:

• HomeFiProxy.sol#L73
• Disputes.sol#L182
• Disputes.sol#L208

[GAS 02] Use > 0 instead != 0 to check if an unsigned int is not 0

Proof of concept:

• Community.sol#L763
• Project.sol#L194

[GAS 03] Use custom error instead string error for the following require statements

Proof of concept:

• Project.sol#L510
• HomeFi.sol#L190
• Community.sol#L383
• Community.sol#L567