Dopex - spidy730's results

Lines of code

https://github.com/code-423n4/2023-08-dopex/blob/main/contracts/perp-vault/PerpetualAtlanticVaultLP.sol#L201

Vulnerability details

Impact

The strict equality check in the subtractLoss function could lead to unintended transaction failures, disrupting the normal operation of the contract.

Proof of Concept

function subtractLoss(uint256 loss) public onlyPerpVault {
    require(
      collateral.balanceOf(address(this)) == _totalCollateral - loss,
      "Not enough collateral was sent out"
    );
    _totalCollateral -= loss;
  } 

It uses == for check however due to potential precision, gas cost, and other variations, this comparison might fail unexpectedly, leading to incorrect behavior

Tools Used

Manual Review

Recommended Mitigation Steps

Instead of using == use >=

function subtractLoss(uint256 loss) public onlyPerpVault {
    require(
      collateral.balanceOf(address(this)) >= _totalCollateral - loss,
      "Not enough collateral was sent out"
    );
    _totalCollateral -= loss;
} 

Assessed type

Error