Platform: Code4rena
Start Date: 16/09/2021
Pot Size: $50,000 USDC
Total HM: 26
Participants: 30
Period: 7 days
Judge: GalloDaSballo
Total Solo HM: 17
Id: 36
League: ETH
Rank: 28/30
Findings: 1
Award: $62.07
🌟 Selected for report: 2
🚀 Solo Findings: 0
4.3799 USDC - $4.38
t11s
Gas is wasted by not packing storage variables in Auction. Combining smaller value types to fill 256 slots would drastically reduce the number of SLOADs and SSTORES used in the contract.
#0 - GalloDaSballo
2021-11-26T01:16:16Z
Agree that packing the booleans would reduce gas cost, as with all findings providing an example is best
🌟 Selected for report: t11s
57.691 USDC - $57.69
t11s
Gas is wasted making settleAuction
public, and using memory
Instead of calldata for its arguments.
#0 - GalloDaSballo
2021-11-26T01:17:34Z
Agree with the finding, would appreciate the explanation as to why that's the case.
From my understanding, a public function will copy it's values from callData to memory, already declaring those array to memory drastically increases the cost of using them