Caviar contest - tnevler's results

Report

Gas Optimizations

[G-1]: The increment in for loop post condition can be made unchecked

Context:

1. for (uint256 i = 0; i < tokenIds.length; i++) { L238
2. for (uint256 i = 0; i < tokenIds.length; i++) { L258
3. for (uint256 i = 0; i < tokenIds.length; i++) { L468
4. for (uint256 j = 0; j < 32; j++) { L13
5. for (uint256 j = 0; j < charCount; j++) { L22
6. for (uint256 i = 32; i < 64; i++) { L33
7. for (uint256 i = 0; i < charCount; i++) { L39

Description:

This can save 30-40 gas per loop iteration.

Recommendation:

Example how to fix. Change:

for (uint256 i = 0; i < orders.length; ++i) {
   // Do the thing
}

To:

for (uint256 i = 0; i < orders.length;) {
   // Do the thing
   unchecked { ++i; }
}

[G-2]: Place subtractions where the operands can't underflow in unchecked {} block

Context:

1. uint256 refundAmount = maxInputAmount - inputAmount; L168

Description:

Some gas can be saved by using an unchecked {} block if an underflow isn't possible because of a previous require() or if-statement.