Platform: Code4rena
Start Date: 03/07/2023
Pot Size: $40,000 USDC
Total HM: 14
Participants: 74
Period: 7 days
Judge: alcueca
Total Solo HM: 9
Id: 259
League: ETH
Rank: 71/74
Findings: 1
Award: $6.07
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: 0xprinc
Also found by: 0x11singh99, 0xAnah, 0xWaitress, 0xkazim, 2997ms, 33audits, 404Notfound, 8olidity, CRIMSON-RAT-REACH, CyberPunks, DanielWang888, Deekshith99, Eeyore, Eurovickk, Inspecktor, JGcarv, John, Jorgect, Kaysoft, LosPollosHermanos, MohammedRizwan, Qeew, QiuhaoLi, Rolezn, TheSavageTeddy, Topmark, Trust, Udsen, a3yip6, alexzoid, bigtone, codegpt, erebus, fatherOfBlocks, ginlee, glcanvas, hunter_w3b, josephdara, kaveyjoe, kutugu, mahdirostami, max10afternoon, oakcobalt, peanuts, pfapostol, ptsanev, qpzm, radev_sw, ravikiranweb3, sces60107, seth_lawson, te_aut, twcctop, zhaojie, ziyou-
6.0655 USDC - $6.07
https://github.com/code-423n4/2023-07-basin/blame/84dd4472a951bfd66f4e92abd8231aa4d00f7398/src/Well.sol#L224
_swapFrom fromToken and toToken should not be the same. Actually, there is no check related to the same from and to token.
But in _getIj same from、to token may revert because only one index can be found after all better check is recommended.
reserves[j] -= amountOut;
There is no check wheather reserves[j] > amountOut，better check in recommended.
#0 - c4-pre-sort
2023-07-12T08:39:53Z
141345 marked the issue as low quality report
#1 - c4-judge
2023-08-04T21:34:44Z
alcueca marked the issue as grade-b