Platform: Code4rena
Start Date: 25/01/2023
Pot Size: $36,500 USDC
Total HM: 11
Participants: 173
Period: 5 days
Judge: kirk-baird
Total Solo HM: 1
Id: 208
League: ETH
Rank: 146/173
Findings: 1
Award: $7.05
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: RaymondFam
Also found by: 0xMirce, AkshaySrivastav, AlexCzm, Aymen0909, BClabs, CodingNameKiki, ElKu, HollaDieWaldfee, Josiah, KIntern_NA, MiniGlome, StErMi, adriro, bin2chen, cccz, chaduke, csanuragjain, gzeon, hihen, holme, libratus, minhquanym, omis, peakbolt, peanuts, rbserver, rvierdiiev, timongty, ubermensch, usmannk, wait, zaskoh
7.046 USDC - $7.05
In the Erc20Quest contract, the withdrawRemainingTokens function allows the owner to withdraw the remaining tokens after the end of the quest, the transferred amount is the balance of the contract minus the unclaimed tokens. However, the Erc1155Quest contract mismatches this logic, the withdrawRemainingTokens function transfers all the contract balance of the token id stored in rewardAmountInWeiOrTokenId. This represents a significant risk on the users' unclaimed Erc1155 tokens after the end of the quest.
Manual Code Review
It is recommended to adjust the withdrawRemainingTokens function to prevent the owner from withdrawing the users' unclaimed ERC1155 tokens.
#0 - c4-judge
2023-02-06T22:34:22Z
kirk-baird marked the issue as duplicate of #42
#1 - c4-judge
2023-02-10T05:03:11Z
kirk-baird changed the severity to QA (Quality Assurance)
#2 - c4-judge
2023-02-10T05:12:14Z
This previously downgraded issue has been upgraded by kirk-baird
#3 - c4-judge
2023-02-14T09:27:47Z
kirk-baird marked the issue as satisfactory
#4 - c4-judge
2023-02-23T23:49:21Z
kirk-baird changed the severity to 2 (Med Risk)