Sherlock contest - wuwe1's results

Decentralized exploit protection.

General Information

Platform: Code4rena

Start Date: 20/01/2022

Pot Size: $80,000 USDC

Total HM: 5

Participants: 37

Period: 7 days

Judge: Jack the Pug

Total Solo HM: 1

Id: 76

League: ETH

Sherlock

Findings Distribution

Researcher Performance

Rank: 29/37

Findings: 2

Award: $36.17

🌟 Selected for report: 0

🚀 Solo Findings: 0

External Links

Code4rena Contest Page Github Contest Repository Github Findings Repository Sherlock

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Auditors

Browse

Contests

Browse

Get in touch

Contact Twitter

Findings Information

🌟 Selected for report: Afanasyevich

Also found by: sirhashalot, wuwe1, ye0lde

Labels

bug

duplicate

G (Gas Optimization)

Awards

36.1718 USDC - $36.17

External Links

Link to GitHub issue

Handle

wuwe1

Vulnerability details

Proof of Concept

The only use of Cleaned state in cleanUp

https://github.com/code-423n4/2022-01-sherlock/blob/main/contracts/interfaces/managers/ISherlockClaimManager.sol#L54

https://github.com/code-423n4/2022-01-sherlock/blob/main/contracts/managers/SherlockClaimManager.sol#L284

This line is followed by _setState(claimIdentifier, State.NonExistent) which set the claim to the default state. _setState(claimIdentifier, State.NonExistent) render _setState(claimIdentifier, State.Cleaned) unnecessary here.

Recommended Mitigation Steps

Remove Cleaned state and _setState(claimIdentifier, State.Cleaned).

#0 - jack-the-pug
2022-03-26T13:46:38Z

Dup #130

Sherlock contest - wuwe1's results

Decentralized exploit protection.

General Information

Findings Distribution

Researcher Performance

External Links

Gas Report - $36.17

Gas Report - $36.17

[G-15] Cleaned state can be removed - $36.17

Findings Information

Labels

Awards

External Links

Handle

Vulnerability details

Proof of Concept

Recommended Mitigation Steps

#0 - jack-the-pug2022-03-26T13:46:38Z

#0 - jack-the-pug
2022-03-26T13:46:38Z