Phuture Finance contest - z3s's results

Non Critical

Use of Floating Pragma:

Contracts should be deployed with the same compiler version and flags that they have been tested with thoroughly. Locking the pragma helps to ensure that contracts do not accidentally get deployed using, for example, an outdated compiler version that might introduce bugs that affect the contract system negatively.

Recommended Mitigation Steps:

Lock the pragma version: use 0.8.7 instead of >=0.8.7.

Gas Optimizations

Use calldata instead of memory:

• https://github.com/code-423n4/2022-04-phuture/blob/main/contracts/UniswapV2PathPriceOracle.sol#L23

For external function's dynamic params, calldata is the cheapest location to use.

Recommended Mitigation Steps:

Change params memory to calldata

Use Custom Errors to save Gas:

Custom errors from Solidity 0.8.4 are cheaper than require messages. https://blog.soliditylang.org/2021/04/21/custom-errors/

++i use less gas than i++:

./contracts/UniswapV2PathPriceOracle.sol
  line: 34   for (uint i = 0; i < path.length - 1; i++) {
  line: 49   for (uint i = 0; i < path.length - 1; i++) {

++i can save some gas use it like other places in code.