Platform: Code4rena
Start Date: 15/07/2021
Pot Size: $80,000 USDC
Total HM: 28
Participants: 18
Period: 7 days
Judge: ghoulsol
Total Solo HM: 18
Id: 20
League: ETH
Rank: 18/18
Findings: 2
Award: $124.95
🌟 Selected for report: 0
🚀 Solo Findings: 0
zer0dot
The contracts do not use an equivalent of SafeERC20, which could result in unexpected behavior.
One example of a missing return value check is in the Dao.sol
contract here
In order to maintain proper accounting, the protocol relies on workarounds like _getAddedBaseAmount()
and _getAddedTokenAmount()
in Pool.sol
here.
Use SafeERC20 (or an equivalent for BEP20) to ensure expected behavior without having to use workarounds.
#0 - SamusElderg
2021-07-26T01:47:01Z
Duplicate of #8