Backed Protocol contest - 0v3rf10w's results

Protocol for peer to peer NFT-Backed Loans.

General Information

Platform: Code4rena

Start Date: 05/04/2022

Pot Size: $30,000 USDC

Total HM: 10

Participants: 47

Period: 3 days

Judge: gzeon

Total Solo HM: 4

Id: 106

League: ETH

Backed Protocol

Findings Distribution

Researcher Performance

Rank: 30/47

Findings: 2

Award: $96.42

🌟 Selected for report: 0

🚀 Solo Findings: 0

Awards

54.2825 USDC - $54.28

Labels

bug
duplicate
QA (Quality Assurance)
sponsor acknowledged

External Links

QA1:

consistently use safeTransfer NFTLoanFacilitator.sol L#88

IERC721(collateralContractAddress).transferFrom(msg.sender, address(this), collateralTokenId);

change this kind of similar to NFTLoanFacilitator.sol L#262,242

IERC721(loan.collateralContractAddress).safeTransferFrom( address(this), sendCollateralTo, loan.collateralTokenId );

QA2:

NFTLoanFacilitator.sol L#165

// will underflow if amount < previousAmount uint256 amountIncrease = amount - previousLoanAmount;

(this don't make sense if underflowed or just add if it's underflowing then it's todo or add a check or can use unchecked{} )

NFTLoanFacilitator.sol L#198 (this too don't make sense if above gets underflowed, also add != being an unsigned integer)

Awards

42.1423 USDC - $42.14

Labels

bug
G (Gas Optimization)
sponsor acknowledged

External Links

Gas1:

shorten revert strings or custom errors to save gas rather than very long strings

Gas2:

uint256 preferred instead of uint types to save gas

Gas3:

NFTLoanFacilitator.sol L#321 use !=0 insted of > for unsigned integers

#0 - wilsoncusack

2022-04-07T15:40:24Z

ack, covered by others as well

AuditHub

A portfolio for auditors, a security profile for protocols, a hub for web3 security.

Built bymalatrax © 2024

Auditors

Browse

Contests

Browse

Get in touch

ContactTwitter