Platform: Code4rena
Start Date: 05/04/2022
Pot Size: $30,000 USDC
Total HM: 10
Participants: 47
Period: 3 days
Judge: gzeon
Total Solo HM: 4
Id: 106
League: ETH
Rank: 30/47
Findings: 2
Award: $96.42
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: IllIllI
Also found by: 0v3rf10w, 0x1f8b, 0xDjango, 0xkatana, BouSalman, CertoraInc, Dravee, FSchmoede, Hawkeye, Kenshin, Meta0xNull, PPrieditis, Ruhum, TerrierLover, VAD37, WatchPug, berndartmueller, csanuragjain, hake, horsefacts, hubble, m9800, rayn, reassor, robee, samruna, securerodd, shenwilly, sorrynotsorry, t11s, teryanarmen, tintin, z3s
54.2825 USDC - $54.28
consistently use safeTransfer NFTLoanFacilitator.sol L#88
IERC721(collateralContractAddress).transferFrom(msg.sender, address(this), collateralTokenId);
change this kind of similar to NFTLoanFacilitator.sol L#262,242
IERC721(loan.collateralContractAddress).safeTransferFrom( address(this), sendCollateralTo, loan.collateralTokenId );
NFTLoanFacilitator.sol L#165
// will underflow if amount < previousAmount uint256 amountIncrease = amount - previousLoanAmount;
(this don't make sense if underflowed or just add if it's underflowing then it's todo or add a check or can use unchecked{} )
NFTLoanFacilitator.sol L#198 (this too don't make sense if above gets underflowed, also add != being an unsigned integer)
🌟 Selected for report: Dravee
Also found by: 0v3rf10w, 0x1f8b, 0xkatana, CertoraInc, FSchmoede, Funen, IllIllI, Kenshin, Meta0xNull, TerrierLover, Tomio, csanuragjain, joshie, obront, rayn, rfa, robee, saian, securerodd, sorrynotsorry, t11s, z3s
42.1423 USDC - $42.14
shorten revert strings or custom errors to save gas rather than very long strings
uint256 preferred instead of uint types to save gas
NFTLoanFacilitator.sol L#321 use !=0 insted of > for unsigned integers
#0 - wilsoncusack
2022-04-07T15:40:24Z
ack, covered by others as well