Platform: Code4rena
Start Date: 05/04/2022
Pot Size: $30,000 USDC
Total HM: 10
Participants: 47
Period: 3 days
Judge: gzeon
Total Solo HM: 4
Id: 106
League: ETH
Rank: 42/47
Findings: 1
Award: $51.87
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: IllIllI
Also found by: 0v3rf10w, 0x1f8b, 0xDjango, 0xkatana, BouSalman, CertoraInc, Dravee, FSchmoede, Hawkeye, Kenshin, Meta0xNull, PPrieditis, Ruhum, TerrierLover, VAD37, WatchPug, berndartmueller, csanuragjain, hake, horsefacts, hubble, m9800, rayn, reassor, robee, samruna, securerodd, shenwilly, sorrynotsorry, t11s, teryanarmen, tintin, z3s
51.8678 USDC - $51.87
Issue#1 : null check for loanAssetContractAddress missing in createLoan
Title : null check for loanAssetContractAddress missing in createLoan
The null check for loanAssetContractAddress is done in lend function where it will fail. However it is good if this null check is added in the createLoan function, so that invalid loanInfo storage is not created in the first place.
Contract : NFTLoanFacilitator.sol Function : createLoan(...)
Add below require statement in createLoan function
require(loanAssetContractAddress != address(0), "NFTLoanFacilitator: invalid loan");
#0 - wilsoncusack
2022-04-08T13:52:16Z
we will probably move this to createLoan but it also need to check the code.length #46