Platform: Code4rena
Start Date: 07/04/2022
Pot Size: $100,000 USDC
Total HM: 20
Participants: 62
Period: 7 days
Judge: LSDan
Total Solo HM: 11
Id: 107
League: ETH
Rank: 52/62
Findings: 1
Award: $87.39
🌟 Selected for report: 0
🚀 Solo Findings: 0
🌟 Selected for report: Dravee
Also found by: 0v3rf10w, 0x1f8b, 0xDjango, 0xNazgul, 0xkatana, Cityscape, Cr4ckM3, FSchmoede, Foundation, Funen, Hawkeye, IllIllI, JMukesh, Meta0xNull, PPrieditis, Picodes, TerrierLover, Tomio, WatchPug, berndartmueller, catchup, delfin454000, dirk_y, ellahi, hickuphh3, ilan, kebabsec, kenta, nahnah, rayn, rfa, robee, rokinot, saian, securerodd, slywaters, sorrynotsorry
87.3915 USDC - $87.39
break && into two require statements to save gas NFTEscrow.sol l#86 JPEGStaking.sol l#45 StrategyPUSDConvex.sol L#181 yVault.sol L#99 FungibleAssetVaultForDAO.sol L#93,194 NFTVault.sol #401
making public to external saves gas NFTEscrow.sol l#81 LPFarming.sol l#114
prefer != instead of > to save gas LPFarming.sol l#218,239,320,337,354 yVaultLPFarming.sol L#101,118,139 JPEGLock.sol L#40 JPEGStaking.sol L#32,46 StrategyPUSDConvex.sol L#182,322,334 yVault.sol L#143,167,170 FungibleAssetVaultForDAO.sol L#108,142,164,180,194 NFTVault.sol L#278,365,401,687,764,770
use prefix
LPFarming.sol l#226 use user.amount += _amount; instead of user.amount = user.amount + _amount;
use prefix ++i instead of ++i LPFarming.sol L#348 StrategyPUSDConvex.sol L#145,231,319 (also no need to set i=0, it's default) NFTVault.sol L#181,184 (also no need to set i=0, it's default)
floating pragma, prefer to set to atleast 0.8.4