JPEG'd contest - Cityscape's results

https://github.com/code-423n4/2022-04-jpegd/blob/main/contracts/vaults/NFTVault.sol#L129 contract is mispelled as "contrat"

/// @param _nftContract The NFT contrat address. It could also be the address of an helper contract

Proposed Change:

/// @param _nftContract The NFT contract address. It could also be the address of an helper contract

No Need to initialize variables with default values

https://github.com/code-423n4/2022-04-jpegd/blob/main/contracts/vaults/FungibleAssetVaultForDAO.sol#L45

address internal constant ETH = address(0);

could be changed to just

address internal constant ETH;

https://github.com/code-423n4/2022-04-jpegd/blob/main/contracts/vaults/NFTVault.sol#L181

for (uint256 i = 0; i < _typeInitializers.length; i++) {
    NFTCategoryInitializer memory initializer = _typeInitializers[i];
    nftTypeValueETH[initializer.hash] = initializer.valueETH;
    for (uint256 j = 0; j < initializer.nfts.length; j++) {
        nftTypes[initializer.nfts[j]] = initializer.hash;
    }
}

Could be changed to

for (uint256 i; i < _typeInitializers.length; i++) {
    NFTCategoryInitializer memory initializer = _typeInitializers[i];
    nftTypeValueETH[initializer.hash] = initializer.valueETH;
    for (uint256 j; j < initializer.nfts.length; j++) {
        nftTypes[initializer.nfts[j]] = initializer.hash;
    }
}

Use pre-increment

https://github.com/code-423n4/2022-04-jpegd/blob/main/contracts/vaults/NFTVault.sol#L181

for (uint256 i = 0; i < _typeInitializers.length; i++) {
    NFTCategoryInitializer memory initializer = _typeInitializers[i];
    nftTypeValueETH[initializer.hash] = initializer.valueETH;
    for (uint256 j = 0; j < initializer.nfts.length; j++) {
        nftTypes[initializer.nfts[j]] = initializer.hash;
    }
}

could be changed to

for (uint256 i = 0; i < _typeInitializers.length; ++i) {
    NFTCategoryInitializer memory initializer = _typeInitializers[i];
    nftTypeValueETH[initializer.hash] = initializer.valueETH;
    for (uint256 j = 0; j < initializer.nfts.length; ++j) {
        nftTypes[initializer.nfts[j]] = initializer.hash;
    }
}

Caching array length

https://github.com/code-423n4/2022-04-jpegd/blob/main/contracts/vaults/NFTVault.sol#L181

for (uint256 i = 0; i < _typeInitializers.length; i++) {
    NFTCategoryInitializer memory initializer = _typeInitializers[i];
    nftTypeValueETH[initializer.hash] = initializer.valueETH;
    for (uint256 j = 0; j < initializer.nfts.length; j++) {
        nftTypes[initializer.nfts[j]] = initializer.hash;
    }
}

Could be changed to

uint typeInitlength = _typeInitializers.length;
for (uint256 i = 0; i < typeInitlength; i++) {
    NFTCategoryInitializer memory initializer = _typeInitializers[i];
    nftTypeValueETH[initializer.hash] = initializer.valueETH;
    for (uint256 j = 0; j < initializer.nfts.length; j++) {
        nftTypes[initializer.nfts[j]] = initializer.hash;
    }
}