Badger-Vested-Aura contest - 0v3rf10w's results

GAS1: prefix ++i should be used and no need to initialise i, best if unchecked() is used to save gas

https://github.com/Badger-Finance/vested-aura/blob/b6abb069431518962e1e0b3e516daa46ae3bdd9b/contracts/MyStrategy.sol#L118

for(uint i = 0; i < length; i++){
            sweepRewardToken(tokens[i]);
        }

Can cache _claims.length as some var for more gas savings below https://github.com/Badger-Finance/vested-aura/blob/b6abb069431518962e1e0b3e516daa46ae3bdd9b/contracts/MyStrategy.sol#L300

for (uint256 i = 0; i < _claims.length; i++) { //@audit

https://github.com/Badger-Finance/vested-aura/blob/b6abb069431518962e1e0b3e516daa46ae3bdd9b/contracts/MyStrategy.sol#L317

GAS2: break && within require to seperate require to save gas (little)

https://github.com/Badger-Finance/vested-aura/blob/b6abb069431518962e1e0b3e516daa46ae3bdd9b/contracts/MyStrategy.sol#L184-187

QA1/NA: _withdrawAll() function is incomplete

https://github.com/Badger-Finance/vested-aura/blob/b6abb069431518962e1e0b3e516daa46ae3bdd9b/contracts/MyStrategy.sol#L182

QA2/NA: open TODO

https://github.com/Badger-Finance/vested-aura/blob/b6abb069431518962e1e0b3e516daa46ae3bdd9b/contracts/MyStrategy.sol#L284 https://github.com/Badger-Finance/vested-aura/blob/b6abb069431518962e1e0b3e516daa46ae3bdd9b/contracts/MyStrategy.sol#L422